Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "[expo-assets] search for key without file extension (… #13789

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

jkhales
Copy link
Contributor

@jkhales jkhales commented Jul 27, 2021

#12624)""

This reverts commit 58a7adb.

Why

The true cause of #13558 was a5dbb5b

Reverting this triggered a fall back measure which fixed the issue in an incomplete way. In detail (thanks @esamelson): Before the revert, we were feeding a dictionary of asset locations that looked like this:

{
  hash1: '/path/to/file/hash1',
  hash2: '/path/to/file/hash2'
}

The iOS AV module was directed to the correct file, but then crashed as these files are missing an extension. Once the revert landed, the local assets could not be found and so they were downloaded from an external URL, avoiding a crash.

Now that assets are saved with an extension, we can reintroduce this safely.

How

re-revert.

Test Plan

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@jkhales jkhales marked this pull request as ready for review July 28, 2021 01:20
@jkhales jkhales requested a review from tsapeta as a code owner July 28, 2021 01:20
@jkhales jkhales requested review from brentvatne and esamelson and removed request for tsapeta July 28, 2021 01:20
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review previously left here is no longer valid, jump to the latest one 👉 #13789 (review)

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jul 28, 2021
@jkhales jkhales merged commit 5d2c1c0 into master Jul 30, 2021
@jkhales jkhales deleted the @jkhales/re-revert-asset branch July 30, 2021 02:13
@expo-bot expo-bot removed the bot: suggestions ExpoBot has some suggestions label Jul 30, 2021
Copy link
Collaborator

@expo-bot expo-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

Looks like I have nothing to complain about 👏 Keep up the good work! 💪

Generated by ExpoBot 🤖 against 6dbaaaf

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 30, 2021
FelipeACP pushed a commit to FelipeACP/expo that referenced this pull request Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants