Revert "Revert "[expo-assets] search for key without file extension (… #13789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#12624)""
This reverts commit 58a7adb.
Why
The true cause of #13558 was a5dbb5b
Reverting this triggered a fall back measure which fixed the issue in an incomplete way. In detail (thanks @esamelson): Before the revert, we were feeding a dictionary of asset locations that looked like this:
The iOS AV module was directed to the correct file, but then crashed as these files are missing an extension. Once the revert landed, the local assets could not be found and so they were downloaded from an external URL, avoiding a crash.
Now that assets are saved with an extension, we can reintroduce this safely.
How
re-revert.
Test Plan
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).