Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packages] match few dependencies to the workspace versions #15069

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Nov 5, 2021

Why

Refs #14561

How

This PR bumps the few dependencies in the Expo packages to match theirs versions to the latest versions used in the workspace.

Test Plan

yarn and yarn test (if available) commands in the modified packages directories have ended with success.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 5, 2021
@expo-bot
Copy link
Collaborator

expo-bot commented Nov 5, 2021

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 386ce87

Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but first would like to see an explanation or test plan validating the graphql package ugprade.

@@ -54,7 +54,7 @@
"babel-plugin-module-resolver": "^4.1.0",
"expo-module-scripts": "^2.0.0",
"fuse.js": "^6.4.6",
"graphql": "^14.2.1",
"graphql": "^15.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ide I have updated earlier GraphQL in Home app, and there was a bit of migration/refactor needed, but from my checks it looks like GraphQL in dev-menu is used very sparse, maybe there are several lines and few method/imports used (all from graphql-tag package). So it looks like the GraphQL is just a required dependency which is not used directly in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being sparsely used doesn't mean it's safe to upgrade. I looked into graphql-tag's commit history to see when support for graphql@15 was confirmed/added. It turns out that happened here, which was included in [email protected]. yarn why says we use [email protected] everywhere so we have the updated version and bumping the graphql version is safe, but we need to understand why dependency upgrades are safe before doing them.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ide Yup, I agree. Thank you for the check and dependencies relation analysis!

@Simek Simek merged commit b5b0cdd into expo:master Nov 7, 2021
@Simek Simek deleted the packages-match-dependencies-to-workspace branch November 7, 2021 13:24
DominickVale pushed a commit to DominickVale/expo that referenced this pull request Nov 24, 2021
prakashbask pushed a commit to prakashbask/expo that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants