-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[notifications][docs] rename and export getExpoPushTokenAsync
parameter type
#21104
Conversation
I guess the fact that this type wasn't exported before makes this not a breaking change. |
Generally, changing types is not considered by us as a breaking change. In this case, since the type was not exported earlier, it is not possible that this change would affect users. It would be possible to break some users code if the type was exported locally, and not on the root level (some people might use the build file import directly to obtain the type information), but this fortunately was not the case. |
getExpoPushTokenAsync
parameter typegetExpoPushTokenAsync
parameter type
Updated the docs as per the latest conversation in the Slack thread with Will and Simek. Let me know your feedback on this. cc: @Simek @kbrandwijk |
i'm about to cut sdk 48 docs, can you cherry-pick this to sdk-48 and ensure it's in sdk 48 docs when this ready? |
Why
Refs: https://exponent-internal.slack.com/archives/C1QMWQ1P0/p1675723296628999
How
After switching Notifications package to leverage the autogenerated docs one of the methods parameters types was missing. This PR renames and exports the problematic param type to make the documentation complete.
Test Plan
The updated docs data file was tested locally, by running docs app.
Preview
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).