[linear-gradient] fix crash when r8 enabled #21580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
lukmccall
reviewed
Mar 7, 2023
| @@ -22,6 +24,8 @@ public class LinearGradientView extends View { | |||
| private int[] mSize = {0, 0}; | |||
| private float[] mBorderRadii = {0, 0, 0, 0, 0, 0, 0, 0}; | |||
|
|
|||
| // Keeps this primary constructor from Proguard/R8 for ViewDefinitionBuilder | |||
| @Keep | |||
lukmccall
approved these changes
Mar 7, 2023
Kudo
added a commit
that referenced
this pull request
Mar 8, 2023
# Why fixes #21562 # How the code here will be stripped by R8: https://github.com/expo/expo/blob/4d234bbfb32b66b3944a0e652eda1e6c67287059/packages/expo-linear-gradient/android/src/main/java/expo/modules/lineargradient/LinearGradientView.java#L25-L27 and then our `ViewDefinitionBuilder` cannot find the primary constructor. this pr adds the keep annotation. i didn't find a way to fix it systematically from expo-modules-core. let's address case by case and expo-linear-gradient first. # Test Plan https://github.com/GaelCO/repro_linearGradient with patch-package for the fix (cherry picked from commit 36421ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fixes #21562
How
the code here will be stripped by R8:
expo/packages/expo-linear-gradient/android/src/main/java/expo/modules/lineargradient/LinearGradientView.java
Lines 25 to 27 in 4d234bb
ViewDefinitionBuildercannot find the primary constructor. this pr adds the keep annotation.i didn't find a way to fix it systematically from expo-modules-core. let's address case by case and expo-linear-gradient first.
Test Plan
https://github.com/GaelCO/repro_linearGradient with patch-package for the fix
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).