[core][iOS] Drop proxiedProperties prop

packages/expo-modules-core/CHANGELOG.md

@@ -24,6 +24,7 @@
 - [iOS] Passed the app context instance down to dynamic types, object builders and convertibles. ([#21819](https://github.com/expo/expo/pull/21819) by [@tsapeta](https://github.com/tsapeta))
 - [iOS] Use `jsi::WeakObject` for weak objects on Hermes. ([#21986](https://github.com/expo/expo/pull/21986) by [@tsapeta](https://github.com/tsapeta))
 - [iOS] Removed legacyViewManager references from ExpoFabricView. ([#22089](https://github.com/expo/expo/pull/22089) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+- [iOS] Dropped `proxiedProperties` prop. ([#22280](https://github.com/expo/expo/pull/22280) by [@tsapeta](https://github.com/tsapeta))
 
 ## 1.2.6 - 2023-03-20
 

packages/expo-modules-core/common/cpp/fabric/ExpoViewProps.cpp

@@ -7,12 +7,27 @@ namespace react = facebook::react;
 
 namespace expo {
 
+/**
+ Borrows the props map from the source props and applies the update given in the raw props.
+ */
+std::unordered_map<std::string, folly::dynamic> propsMapFromProps(const ExpoViewProps &sourceProps, const react::RawProps &rawProps) {
+  // Move the contents of the source props map – the source props instance will not be used anymore.
+  std::unordered_map<std::string, folly::dynamic> propsMap = std::move(sourceProps.propsMap);
+
+  // Iterate over values in the raw props object.
+  // Note that it contains only updated props.
+  rawProps.iterateOverValues([&propsMap](react::RawPropsPropNameHash hash, const char *name, const react::RawValue &value) {
+    std::string propName(name);
+    propsMap[propName] = (folly::dynamic)value;
+  });
+
+  return propsMap;
+}
+
 ExpoViewProps::ExpoViewProps(const react::PropsParserContext &context,
                              const ExpoViewProps &sourceProps,
                              const react::RawProps &rawProps)
                              : ViewProps(context, sourceProps, rawProps),
-                               proxiedProperties(
-                                 facebook::react::convertRawProp(context, rawProps, "proxiedProperties", sourceProps.proxiedProperties, {})) {
-}
+                               propsMap(propsMapFromProps(sourceProps, rawProps)) {}
 
 } // namespace expo

packages/expo-modules-core/common/cpp/fabric/ExpoViewProps.h

@@ -19,7 +19,10 @@ class ExpoViewProps final : public facebook::react::ViewProps {
 
 #pragma mark - Props
 
-  const folly::dynamic proxiedProperties;
+  /**
+   A map with props stored as `folly::dynamic` objects.
+   */
+  std::unordered_map<std::string, folly::dynamic> propsMap;
 };
 
 } // namespace expo

packages/expo-modules-core/ios/Fabric/ExpoFabricView.swift

@@ -68,6 +68,13 @@ public class ExpoFabricView: ExpoFabricViewObjC {
     viewManager.callLifecycleMethods(withType: .didUpdateProps, forView: view)
   }
 
+  /**
+   Returns a bool value whether the view supports prop with the given name.
+   */
+  public override func supportsProp(withName name: String) -> Bool {
+    return viewManagerPropDict?.index(forKey: name) != nil
+  }
+
   /**
    The function that is called by Fabric when the view is unmounted and is being enqueued for recycling.
    It can also be called on app reload, so be careful to wipe out any dependencies specific to the currently running AppContext.

packages/expo-modules-core/ios/Fabric/ExpoFabricViewObjC.h

@@ -37,6 +37,8 @@
 
 - (void)viewDidUpdateProps;
 
+- (BOOL)supportsPropWithName:(nonnull NSString *)name;
+
 - (void)prepareForRecycle;
 
 #pragma mark - Methods injected to the class in runtime