Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][ios] Fix passing JavaScriptObject and view props #22427

Merged
merged 1 commit into from
May 9, 2023

Conversation

lukmccall
Copy link
Contributor

Why

Makes sure that JavaScriptObject can be passed to the native world.
Fix props not being passed correctly.

Test Plan

  • workshop app ✅
  • NCL ✅

@expo-bot
Copy link
Collaborator

expo-bot commented May 9, 2023

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against edf3ae9

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 9, 2023
@lukmccall lukmccall merged commit 0ee8fc1 into main May 9, 2023
@lukmccall lukmccall deleted the @lukmccall/core/fix-passing-js-object-and-props branch May 9, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants