Updated vendored react-native-webview to v13.2.2 #22913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleqsio
commented
Jun 15, 2023
| @@ -287,33 +287,35 @@ const config: VendoringTargetConfig = { | |||
| `, | |||
There was a problem hiding this comment.
@Kudo here's some changes that I'd appreciate a review on
aleqsio
commented
Jun 15, 2023
| @@ -590,6 +590,24 @@ const vendoredModulesConfig: { [key: string]: VendoredModuleConfig } = { | |||
| sourceAndroidPackage: 'com.reactnativecommunity.webview', | |||
| targetAndroidPackage: 'versioned.host.exp.exponent.modules.api.components.webview', | |||
| }, | |||
| { | |||
aleqsio
force-pushed
the
@aleqsio/version-react-native-webview-for-sdk49
branch
from
97affe5
to
b0bee06
Compare
Kudo
reviewed
Jun 15, 2023
| find: /@implementation RNCWebViewManager\s*{/, | ||
| replaceWith: '$&\n NSString *_scopeKey;', | ||
| }, | ||
| { | ||
| paths: 'RNCWebViewManager.m', | ||
| paths: 'RNCWebViewManager.mm', | ||
| find: '*webView = [RNCWebView new];', | ||
| replaceWith: '*webView = [RNCWebView new];\n webView.scopeKey = _scopeKey;', |
There was a problem hiding this comment.
please help to double check all these transforms are updated correctly. the [RNCWebView new] seems not there in the current code.
There was a problem hiding this comment.
Sorry, missed that, will double check to see if all transforms got updated.
Perhaps we should make the vendoring process error out if a transform never got applied?
There was a problem hiding this comment.
Perhaps we should make the vendoring process error out if a transform never got applied?
sounds good 👍
|
Thank you for the catch @Kudo, I've checked that all code transformations for iOS get applied correctly. |
3 tasks
Kudo
approved these changes
Jun 19, 2023
tsapeta
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
SDK49
How
It needed some changes to the legacy vendoring code. The new version stores native files in separate folders for new and old arch and uses gradle files to combine two folders.
Test Plan
Tested manually on both platforms.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).