Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][iOS] Allow CGFloat to be used as an argument type #25140

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Oct 31, 2023

Why

It was not possible to use a common CGFloat type as an argument.

How

Made CGFloat conform to AnyArgument

Test Plan

Added a unit test

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 31, 2023
@tsapeta tsapeta marked this pull request as ready for review October 31, 2023 10:23
@tsapeta tsapeta merged commit 728d4fb into main Nov 1, 2023
1 check passed
@tsapeta tsapeta deleted the @tsapeta/ios/allow-cgfloat-arguments branch November 1, 2023 09:03
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants