Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite] more sqlite next api fix #25637

Merged
merged 4 commits into from
Nov 29, 2023
Merged

[sqlite] more sqlite next api fix #25637

merged 4 commits into from
Nov 29, 2023

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Nov 29, 2023

Why

fix some problems finding from dogfooding and #25618

How

Test Plan

  • check that :memory: file should not be created
  • add a test case for utf8

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 29, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 29, 2023
@Kudo Kudo marked this pull request as ready for review November 29, 2023 14:20
@Kudo Kudo merged commit e900485 into main Nov 29, 2023
11 checks passed
@Kudo Kudo deleted the @kudo/sqlite-next-fix branch November 29, 2023 15:30
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

fix some problems finding from dogfooding and expo#25618

# How

- fix the `:memory:` db being accidentally created as a file.
- fix utf8 issue on ios
- fix incorrect test case from expo#25623

# Test Plan

- check that `:memory:` file should not be created
- add a test case for utf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants