Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blur): Migrate web to a function component and fix reanimated errors #27721

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Mar 17, 2024

Why

  • setNativeProps was removed so we need to set the style props directly. This can be reproduced by opening NCL and going to the blur route.
  • Tested the change in both safari and chrome.
  • This PR also drops support for older browsers in favor of the unsupported style warning.

@EvanBacon EvanBacon requested a review from tsapeta as a code owner March 17, 2024 17:36
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 17, 2024
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 17, 2024
@EvanBacon EvanBacon merged commit 7433765 into main Mar 18, 2024
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/blur/update-web branch March 18, 2024 03:45
marklawlor pushed a commit that referenced this pull request Mar 18, 2024
…ors (#27721)

# Why

- [`setNativeProps` was
removed](necolas/react-native-web@e68c327)
so we need to set the style props directly. This can be reproduced by
opening NCL and going to the blur route.
- Tested the change in both safari and chrome.
- This PR also drops support for older browsers in favor of the
unsupported style warning.

---------

Co-authored-by: Expo Bot <[email protected]>
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants