Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Upgrade maps to 1.13.0 #28007

Merged
merged 3 commits into from
Apr 4, 2024
Merged

[go] Upgrade maps to 1.13.0 #28007

merged 3 commits into from
Apr 4, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Upgrades react-native-maps to 1.13.0

How

Note: I couldn't build an iOS project with Google Maps included. I'll take a closer look later. It's a known issue, but the proposed solution didn't work (react-native-maps/react-native-maps#3597).

Test Plan

  • expo go with NCL ✅

@lukmccall lukmccall requested a review from Kudo April 3, 2024 11:57
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 3, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 3, 2024

The Pull Request introduced fingerprint changes against the base commit: 7abb487

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-maps/ios",
    "reasons": [
      "expoAutolinkingIos"
    ],
    "hash": "12cf75d066caa6da27878642c164fc524177c526"
  },
  {
    "type": "dir",
    "filePath": "ios",
    "reasons": [
      "bareNativeDir"
    ],
    "hash": "7af4666d9581b1b19348b00fc7301f69db814b6d"
  }
]

Generated by PR labeler 🤖

Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help to resolve this test-suite ios-build error before merging. thanks for the cleanup vendoring code

@brentvatne
Copy link
Member

looks like we need to update podfile.lock

@expo-bot
Copy link
Collaborator

expo-bot commented Apr 4, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 96a1b31

@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Apr 4, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment +4 1.62 MB brentvatne
npm/[email protected] Transitive: environment, filesystem, network, shell +17 14.9 MB brentvatne
npm/[email protected] Transitive: environment, eval, filesystem, network, shell +23 28.3 MB kudochien
npm/[email protected] Transitive: environment, filesystem, network, shell +17 14.2 MB brentvatne
npm/[email protected] Transitive: environment, filesystem, network, shell +17 14.7 MB lukmccall
npm/[email protected] Transitive: environment, filesystem, network, shell +18 14.2 MB brentvatne
npm/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +48 25.8 MB brentvatne

🚮 Removed packages: npm/@apidevtools/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@eslint-community/[email protected], npm/@eslint-community/[email protected], npm/@expo/[email protected], npm/@expo/[email protected], npm/@expo/[email protected], npm/@expo/[email protected], npm/@floating-ui/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@mdx-js/[email protected], npm/@mdx-js/[email protected], npm/@mdx-js/[email protected], npm/@nodelib/[email protected], npm/@nodelib/[email protected], npm/@octokit/[email protected], npm/@octokit/[email protected], npm/@octokit/[email protected], npm/@octokit/[email protected], npm/@ocular-d/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@radix-ui/[email protected], npm/@reach/[email protected], npm/@sentry/[email protected], npm/@tailwindcss/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@testing-library/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@ungap/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@lukmccall lukmccall merged commit ff8e715 into main Apr 4, 2024
30 of 31 checks passed
@lukmccall lukmccall deleted the @lukmccall/maps/upgrade branch April 4, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants