[ios][store-review] Refactor isSupported to isAvailableSync #6195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danibonilha
changed the title
danibonilha
changed the title
brentvatne
requested changes
Nov 6, 2019
EvanBacon
requested changes
Nov 7, 2019
|
Also great work on this the gifs are really appreciated! |
danibonilha
force-pushed
the
refactor/store-review-async-support
branch
3 times, most recently
from
73e4e4d
to
5524bd9
Compare
|
Updated Screenshots
|
danibonilha
force-pushed
the
refactor/store-review-async-support
branch
from
5524bd9
to
9f1836b
Compare
EvanBacon
approved these changes
Nov 11, 2019
EvanBacon
reviewed
Nov 11, 2019
danibonilha
force-pushed
the
refactor/store-review-async-support
branch
from
9f1836b
to
7e77414
Compare
danibonilha
force-pushed
the
refactor/store-review-async-support
branch
from
7e77414
to
2f19dce
Compare
|
Hey @brentvatne could you re-review it please? |
danibonilha
force-pushed
the
refactor/store-review-async-support
branch
from
2f19dce
to
5aa504c
Compare
brentvatne
approved these changes
Nov 14, 2019
|
thanks @danibonilha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR refactors
isSupportedmethod fromStoreReviewmodule toisAvailableSync#6129 issue
How
I've modified native code, package store-review and native-components to use
isAvailableSyncTest Plan
I wrote a new test suite to validate this change