fix: use union type in DocumentPicker #7064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This means that if
type === 'success'
thentypeof uri === 'string'
instead ofstring
orundefined
. This matches the docs as well: https://docs.expo.io/versions/latest/sdk/document-picker/#documentpickergetdocumentasyncoptionsI suppose the undocumented fields in the return type is for web?
How
See "why". I made this change in the GitHub web UI.
Test Plan
I changed it locally and it works like I expected