Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blur] Convert Android and web to class components #8856

Merged
merged 3 commits into from
Jun 18, 2020
Merged

[blur] Convert Android and web to class components #8856

merged 3 commits into from
Jun 18, 2020

Conversation

EvanBacon
Copy link
Contributor

Why

  • We won't have RNW 12 ready for 38, RNW 11 Animated doesn't support functional components.
  • For parity Android is converted back to match the other 2 components.

Test Plan

  • Added a unit test that passes if the current version of RNW works with expo-blur.

@EvanBacon EvanBacon added Platform: web Using Expo in the browser BlurView labels Jun 18, 2020
@EvanBacon EvanBacon self-assigned this Jun 18, 2020
@EvanBacon EvanBacon requested a review from ide June 18, 2020 00:33
@github-actions
Copy link
Contributor

Native Component List for this branch is ready

@EvanBacon EvanBacon marked this pull request as ready for review June 18, 2020 00:40
@EvanBacon EvanBacon merged commit f234b14 into master Jun 18, 2020
@EvanBacon EvanBacon deleted the @evanbacon/blur/use-component-for-web branch June 18, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ide ide ide approved these changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela

Assignees

@EvanBacon EvanBacon

Labels
BlurView Platform: web Using Expo in the browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @ide