[location] Add iso country code to reverse geocoding response #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/location/document-missing-iso-country-code
branch
from
04380fa
to
19ef620
Compare
|
Native Component List for this branch is ready |
|
Damn, the changelog gets me every time. Thank god it's warning 😄 |
tsapeta
approved these changes
Jun 22, 2020
Co-authored-by: Tomasz Sapeta <[email protected]>
byCedric
deleted the
@bycedric/location/document-missing-iso-country-code
branch
esamelson
pushed a commit
that referenced
this pull request
Jun 24, 2020
* [location] Add isoCountryCode to reverse geocoding lookup * [docs] Add isoCountryCode to reverse geocoding lookup * [docs] Add isoCountryCode to changelog item * [docs] Add code quotes around properties in changelog Co-authored-by: Tomasz Sapeta <[email protected]> Co-authored-by: Tomasz Sapeta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #8912
How
Looking at the response from the API, this value exists in the
countryorpoliticalcomponent undershort_name. Luckily this is already implemented in the native implementation in both Android and iOS 😄! It was only missing in the fallback to the Google reverse geocoding API and in theAddresstype.Test Plan
Run this change in
apps/bare-expo, and it works without issues on both the emulator and simulator.