Skip to content
This repository has been archived by the owner on Feb 15, 2019. It is now read-only.

Expose renderNavigationView on DrawerNavigation #181

Closed
sibelius opened this issue Oct 19, 2016 · 7 comments
Closed

Expose renderNavigationView on DrawerNavigation #181

sibelius opened this issue Oct 19, 2016 · 7 comments

Comments

@sibelius
Copy link
Contributor

DrawerNavigation uses DrawerLayout under the hood to create the Drawer

I've tried to create a custom View that has a ListView inside Drawer using renderHeader, but it does not scroll well

I think that exposing renderNavigationView method on DrawerNavigation can help on this case and other custom views inside Drawer

sibelius added a commit to sibelius/ex-navigation that referenced this issue Oct 19, 2016
this enable render a custom component inside Drawer
this is not possible using renderHeader,
when you have a ListView inside your custom component

fix expo#181
@JonasJonny
Copy link

Exactly what I was looking for. Thanks.

But how is it possible to pass DrawerNavigationItem's into custom renderNavigationView component for {this._renderDrawerItems()}?

@sibelius
Copy link
Contributor Author

hmm, this is not possible yet on my PR (#182)

but u can easily pass this props to it, I can add it

@skevy do u think this PR (#182) could get in master?

@skevy skevy closed this as completed Oct 28, 2016
@skevy
Copy link
Contributor

skevy commented Oct 28, 2016

Merged!

expbot pushed a commit that referenced this issue Oct 28, 2016
this enable render a custom component inside Drawer
this is not possible using renderHeader,
when you have a ListView inside your custom component

fix #181

Closes #182

fbshipit-source-id: 726cc8e
@sibelius
Copy link
Contributor Author

sibelius commented Nov 4, 2016

@annelorraineuy
Copy link

I'm stuck with how to pass the DrawerNavigationItems into the custom renderNavigationView component / #181 . Would anyone care to explain how this could be done?

@sibelius
Copy link
Contributor Author

@annelorraineuy it is not possible to pass DrawerNavigationItems into renderNavigationView yet

we need another PR to address this

@annelorraineuy
Copy link

Thanks for replying so quickly @sibelius. Do you know a work-around to make let's say Listview menu items inside the custom renderNavigationView work? If I make the menu items get the master stack and just push the routes from that.. Will that work according to how this is built?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants