Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router test runs into timeout issues on slow aarch64 hardware #4886

Closed
grisu48 opened this issue Apr 8, 2022 · 1 comment
Closed

Router test runs into timeout issues on slow aarch64 hardware #4886

grisu48 opened this issue Apr 8, 2022 · 1 comment
Labels

Comments

@grisu48
Copy link
Contributor

grisu48 commented Apr 8, 2022

We encounter a "Timeout of 2000ms exceeded" error on a rather low-powered aarch64 device when running npm run test-ci:

Router
✔ should return a function with router methods
✔ should support .use of other routers (38ms)
✔ should support dynamic routes
✔ should handle blank URL
✔ should handle missing URL
1) should not stack overflow with many registered routes

17 passing (5s)
1 failing

  1) Router
       should not stack overflow with many registered routes:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/opt/express/test/Router.js)
      at /opt/express/test/Router.js:73:11
      at Layer.handle [as handle_request] (lib/router/layer.js:35:103)
      at next (lib/router/route.js:36:802)
      at Route.dispatch (lib/router/route.js:34:677)
      at Layer.handle [as handle_request] (lib/router/layer.js:35:103)
      at /opt/express/lib/router/index.js:82:415
      at Function.process_params (lib/router/index.js:93:170)
      at next (lib/router/index.js:82:31)
      at Function.handle (lib/router/index.js:67:194)
      at Context.<anonymous> (test/Router.js:76:12)
      at processImmediate (node:internal/timers:464:21)

Reproducer

I run this on an emulated aarch64 VM on my x86_64 laptop. The issue occurs on one of our hardware aarch64 workers

git clone https://github.com/expressjs/express.git
cd express
npm config set shrinkwrap false && npm rm --silent --save-dev connect-redis && npm run test-ci

Possible fix

@dcermak came up with a possible fix: Add --timeout 7500 to the package.json. I will add a pull request with the fix.

This solved the issue on our virtual machine.

@dougwilson
Copy link
Contributor

Closing as the PR was merged in to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants