-
-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout for mocha to 7500 #4887
Conversation
Thanks @grisu48 ! The particular test referenced in the issue can take a bit due to the memory allocation for it. Is that the only test that times out? If so, I can update your PR to isolate the expanded test timeout only to that single test. |
Yes, the rest of the CI works nicely with this timeout. With the here provided fix, the following test runs completes without any errors:
The Important: Since the CI test runs cancels after the first failure, I cannot comment if other tests are not affected yet. Will look on Monday at the logs and try to determine if other tests are affected as well. |
@dougwilson I adapted your solution and tested in on my affected aarch64 VM, where 5/5 test runs are now passing. Please review again, IMHO this would solve the issue. |
Thank you for merging! 🙂 👍 |
In order to fix some timeout issues in the CI on low-end hardware we increase
the timeout for mocha to 7500ms.
This is a proposed fix for #4886