build: add Node v20 and v21 into ci with minor version removed #5310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar to #5190, but removed the hardcoded minor versions. |
|
Example installation Node.js v20, without minor version specified. |
|
I will close this pull request as per the discussion in #5190 (comment). It has been decided that we should maintain the minor version in the pipeline. I appreciate your proposal and your understanding in this matter. Thank you @ckng0221! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Node.js v20 and v21 into the CI pipeline.
Remove hardcoded minor version (eg.
19.7) from the node-version for those versions without specified dev dependencies.The nvm will automatically install the latest published minor version of Node.js, without the need of update every time.