Split examples from Express Core #5311
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will move this PR to draft again, as I want to include a pipeline to support integration tests again. |
UlisesGascon
added
the
semver-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial approach to #5309 (cc: @dougwilson ). All feedback is super welcome. 🙌
What is this about?
The main idea is to remove the
/examplesand the related tests from this repository and relocate them inhttps://github.com/expressjs/examplesThis PR will remove the
/examples/**(a13e252) and/test/acceptance/**(555e726) from this repo and update the documentation regarding the examples to point out the new repository to the users (d9da9ad)What are the dependencies for this PR?
This PR won't make sense unless we transfer my repository https://github.com/UlisesGascon/express-examples to the express org as
https://github.com/expressjs/examples.The other repo has the same git historial as this repo and the Express core stuff have been removed, so only the examples and the acceptance tests are there. See UlisesGascon/express-examples#1 for more details.
What will happen with the PRs related to examples?
Well, the idea is to port them (as both repos have the same history). As an example I port one commit (UlisesGascon/express-examples@51db5b6 from #5190) in this PR: UlisesGascon/express-examples#3