remove --bail from test script #5962
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original intent of bail was that the test script was used only for local dev, and there was a CI script w/o bail ab8d116
Eventually CI script reused local script, so bail got into CI. 12310c5
bail will stop test execution after the first failure
aside
can run
npm test -- --bail=false
to override it locally or just run your own watch scriptI prefer removing bail instead of changing the ci script to something like passing
-- --bail=false