Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove --bail from test script #5962

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jonchurch
Copy link
Member

@jonchurch jonchurch commented Sep 14, 2024

Original intent of bail was that the test script was used only for local dev, and there was a CI script w/o bail ab8d116

Eventually CI script reused local script, so bail got into CI. 12310c5

bail will stop test execution after the first failure

aside

can run npm test -- --bail=false to override it locally or just run your own watch script

I prefer removing bail instead of changing the ci script to something like passing -- --bail=false

"test-ci": "nyc --exclude examples --exclude test --exclude benchmarks --reporter=lcovonly --reporter=text npm test -- --bail=false"

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonchurch! Actually I suffered from this recently 🤣

@jonchurch jonchurch merged commit 6340d15 into expressjs:master Sep 30, 2024
19 checks passed
@jonchurch jonchurch deleted the jonchurch/no-bail branch September 30, 2024 20:49
@wesleytodd
Copy link
Member

OMG I am so glad you did this. I have been removing it on my own while I test locally then adding it back in. Sorry I missed this PR, but glad you landed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants