-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #218
Update README.md #218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After v2 there is no default export, you need to call "createStream" method.
Closes #217 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This keeps popping up, and in the interim there is some confusion. Can we add to the example the specific version of the rotating-file-stream
the example represents?
+1 - please push this README change; it just happened to me and had to google to get here :) |
I'm just waiting for the requested change to be made from the review comment. If I don't hear back in a week or so I will make the change myself instead, but then OP will loose credit on it, so wanted to give a chance. |
@Allanbikundo thank for this PR! There's a request here to update the docs to reference the version of Is this a change you can make? That seems to be the only thing left to get this PR in. |
Hello there
So rotating-file-stream now needs one to call the function createStream to work