build: support Node.js 10.x

expressjs · Jun 9, 2018 · 92d6767 · 92d6767
1 parent fcad676
commit 92d6767
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -12,6 +12,7 @@ node_js:
   - "7.10"
   - "8.11"
   - "9.11"
+  - "10.4"
 sudo: false
 cache:
   directories:

diff --git a/appveyor.yml b/appveyor.yml
@@ -12,10 +12,13 @@ environment:
     - nodejs_version: "7.10"
     - nodejs_version: "8.11"
     - nodejs_version: "9.11"
+    - nodejs_version: "10.4"
 cache:
   - node_modules
 install:
-  - ps: Install-Product node $env:nodejs_version
+  - ps: >-
+      try { Install-Product node $env:nodejs_version -ErrorAction Stop }
+      catch { Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) }
   - npm config set shrinkwrap false
   - if "%nodejs_version%" equ "0.8" npm config set strict-ssl false
   - if "%nodejs_version%" equ "0.8" npm rm --save-dev istanbul

diff --git a/test/test.js b/test/test.js
@@ -93,11 +93,11 @@ describe('serveIndex(root)', function () {
   })
 
   it('should treat an ENAMETOOLONG as a 414', function (done) {
-    var path = Array(11000).join('foobar')
-    var server = createServer()
+    var dir = path.join(fixtures, Array(10000).join('/foobar'))
+    var server = createServer(dir)
 
     request(server)
-    .get('/' + path)
+    .get('/')
     .expect(414, done)
   })