Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stat-absent checks #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added stat-absent checks #102

wants to merge 1 commit into from

Conversation

N247S
Copy link

@N247S N247S commented Aug 30, 2021

Added checks for the presence of the stat.mtime and stat.size properties in the createHtmlFileList function.

For more details see this issue comment for more details.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added a note and also need tests and if stats can really be missing, our docs needs to note that too where we expose them

? file.stat.mtime.toLocaleDateString() + ' ' + file.stat.mtime.toLocaleTimeString()
: '';
var size = file.stat && !isDir
var size = file.stat && file.stat.size && !isDir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a bug on Node.js regarding this? The fs.stat cannot return something other than a stat object unless it provides an error. Or is there missing logic in here regarding the error from fs.stat not getting propogated? We should probably fix the reason the stat is missing rather than the symptom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants