Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace smilies with better versions, refresh comments list after new comment is saved #97

Merged
merged 14 commits into from
Jan 23, 2024

Conversation

iantrudell
Copy link

@iantrudell iantrudell commented Jun 24, 2022

Feel free to modify this (need to add update SQL I think for the smilies). The PNG versions are transparent and improve on the GIF versions.

For the refresh comments list part, the objective is to reload/refresh the comments list after a new comment is submitted/saved. Currently, it doesn't always update the comment lists and users frequently double-post as a consequence.

@exstreme
Copy link
Owner

  1. May be better disable button?
  2. How about delay with another message (or yoy set this value to 0 in settings?)
  3. Can you describe, how to repeat this case?

@iantrudell iantrudell changed the title Refresh comments list after new comment is saved Replace smilies with better versions, refresh comments list after new comment is saved Mar 4, 2023
@iantrudell
Copy link
Author

  1. May be better disable button?
  2. How about delay with another message (or yoy set this value to 0 in settings?)
  3. Can you describe, how to repeat this case?
  1. Not sure what you mean by disable button
  2. Not sure what you mean
  3. Load a page with many comments, then submit a new comment. Currently, it won't reliably/automatically refresh the comments list to show the newly posted comment. With this change, it will always refresh the comments list after a user adds a new comment.

@exstreme
Copy link
Owner

exstreme commented Mar 5, 2023

@iantrudell may be can you share link, where we can reproduce and view the bug?
And your branch has conflicts

@Globulopolis
Copy link
Collaborator

3. Load a page with many comments, then submit a new comment. Currently, it won't reliably/automatically refresh the comments list to show the newly posted comment. With this change, it will always refresh the comments list after a user adds a new comment.

I have seen this bug when comments displayed as list view(not a tree). List won't update(and no errors).

@Globulopolis Globulopolis merged commit 2b6be61 into exstreme:master Jan 23, 2024
@exstreme
Copy link
Owner

exstreme commented Jan 23, 2024

Is it 18x18 too small resolution in 2024?
And gif can have animation and can be transparent too!
SQL isn't updatable, only for new installs

Globulopolis added a commit to Globulopolis/Jcomments-4 that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants