Refactor version logging in generated bindings #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in bindings * Minor simplifications applied
|
/bindings |
Ilia-Kosenkov
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very helpful to have the information of which clang version was used,
and which R version was used in the generated bindings.
Unfortunately I introduced this in a very verbose way, when there are
facilities to include text lines in the generated bindings.
I've also cleaned up a little bit the
build.rs.I feel like this script is touched by us maintainers all the time, and
will be a constant nuisance, so I do vote we make it as easy to work with,
and as clear as possible. That's the spirit behind this PR.