fix: move metrics call so failures doesn't double call

external-secrets · Nov 3, 2019 · 37be08b · 37be08b
1 parent 608c596
commit 37be08b
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/lib/poller.js b/lib/poller.js
@@ -97,6 +97,13 @@ class Poller {
 
     try {
       await this._upsertKubernetesSecret()
+
+      this._metrics.observeSync({
+        name: this._name,
+        namespace: this._namespace,
+        backend: this._secretDescriptor.backendType,
+        status: 'success'
+      })
     } catch (err) {
       this._logger.error(err, `failure while polling the secret ${this._name}`)
       this._metrics.observeSync({
@@ -111,13 +118,6 @@ class Poller {
     if (!this._stopped) {
       this._setNextPoll()
     }
-
-    this._metrics.observeSync({
-      name: this._name,
-      namespace: this._namespace,
-      backend: this._secretDescriptor.backendType,
-      status: 'success'
-    })
   }
 
   /**