fix: trigger poll if last sync was in the future

external-secrets · Nov 4, 2019 · 9608ddb · 9608ddb
1 parent 8839f5d
commit 9608ddb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/lib/poller.js b/lib/poller.js
@@ -210,8 +210,14 @@ class Poller {
         return this._setNextPoll(0)
       }
 
+      const now = Date.now()
       const lastPollTime = Date.parse(lastSync) || 0
-      const elapsedTime = Date.now() - lastPollTime
+
+      if (lastPollTime > now) {
+        return this._setNextPoll(0)
+      }
+
+      const elapsedTime = now - lastPollTime
       const nextPollIn = Math.max(this._intervalMilliseconds - elapsedTime, 0)
 
       return this._setNextPoll(nextPollIn)

diff --git a/lib/poller.test.js b/lib/poller.test.js
@@ -302,16 +302,14 @@ describe('Poller', () => {
         expect(poller._setNextPoll.calledWith(poller._intervalMilliseconds - elapsedTime)).to.equal(true)
       })
 
-      it('with last sync in the future - queues poll', async () => {
+      it('with last sync in the future - triggers poll', async () => {
         fakeDate.setFullYear(fakeDate.getFullYear() + 1)
-
-        const elapsedTime = 0
-        clock.tick(elapsedTime)
+        fakeStatus.body.status.lastSync = fakeDate.toISOString()
 
         await poller._scheduleNextPoll()
 
         expect(externalSecretsApiMock.status.get.calledWith()).to.equal(true)
-        expect(poller._setNextPoll.calledWith(poller._intervalMilliseconds)).to.equal(true)
+        expect(poller._setNextPoll.calledWith(0)).to.equal(true)
       })
 
       it('with old last sync - triggers poll', async () => {