Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cors issue #1200

Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix cors issue #1200

merged 3 commits into from
Aug 10, 2023

Conversation

yadue
Copy link
Contributor

@yadue yadue commented Aug 10, 2023

I had to redo the commit, creating new pull request.

About the try {} catch {}. Literally every single JSON.parse is made like that in that repository.

@extesy
Copy link
Owner

extesy commented Aug 10, 2023

@yadue I've checked your change on https://www.reddit.com/search/?q=site%3Aredgifs.com&sort=new&t=all and it works for videos (www.redgifs.com links) but does not work for images (i.redgifs.com links). Would you be able to make it work with images as well?

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yadue
Copy link
Contributor Author

yadue commented Aug 10, 2023

@extesy added

@extesy extesy merged commit 6e54ba6 into extesy:master Aug 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants