Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mediawiki plugin thumbnail selector #1317

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

reohjs
Copy link
Contributor

@reohjs reohjs commented Feb 29, 2024

Use a less precise attribute selector since mediawiki thumbnail URLs no longer use the full URL

E.g. https://runescape.wiki/

Use a less precise selector since mediawiki thumbnail URLs no longer use the full URL
@extesy
Copy link
Owner

extesy commented Feb 29, 2024

I'm concerned that the new selector img[src*="thumb/"] is too generic and will have false positive matches of various non-wiki websites. Is there anything else about mediawiki urls that would help make the selector narrower?

Keep specificity to mediawiki
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@extesy extesy merged commit 37ff7ce into extesy:master Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants