Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image lock : added pan around for videos #767

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

GrosPoulet
Copy link
Collaborator

No description provided.

@extesy extesy merged commit b23102b into extesy:master Jul 29, 2021
@GrosPoulet
Copy link
Collaborator Author

@EhsanKia i added pan around functionality for videos too.
It would be nice to add controls (play, pause,...) to videos, as in Imagus, i'll try to give it a shot since i did something similar when a video is opened in a separate window (W action key).

@EhsanKia
Copy link
Contributor

EhsanKia commented Jul 30, 2021

I don't fully recall how it was on Imagus since it's been a while, but is it not as simple as settings controls=true on the <video> element? I usually do it manually by right clicking the (locked) video and checking "enable video controls" which does the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants