Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cjs #119

Merged
merged 4 commits into from
Dec 2, 2023
Merged

Support cjs #119

merged 4 commits into from
Dec 2, 2023
+55 −0

Conversation

olsonpm
Copy link
Contributor

@olsonpm olsonpm commented Dec 1, 2023

addresses #118

  • use esbuild to bundle a cjs compatible version of this package
  • deprecate cjs in a similar way to vite, including a warning with environment variables to ignore or trace.

Let me know if and how you want me to add tests for this

ndaidong and others added 4 commits November 6, 2023 16:48
@ndaidong ndaidong changed the base branch from main to dev December 2, 2023 03:25
@ndaidong ndaidong merged commit 306b847 into extractus:dev Dec 2, 2023
5 checks passed
ndaidong added a commit that referenced this pull request Dec 2, 2023
@ndaidong
v7.0.8
156bae3 
- Merge pr #119 by @olsonpm (issue #118)
- Add link to GitHub Action Wrapper by @chriscarrollsmith (issue #114)
- Update dependencies, CI settings & examples
@ndaidong ndaidong mentioned this pull request Dec 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olsonpm @ndaidong