Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to resolve installation issues #5

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

IndigoDosSantos
Copy link

@exx8

  • Problem: The previous requirements.txt file caused installation errors.
  • Solution: This pull request includes a revised requirements.txt file that addresses the installation issues. I've tested it to ensure successful installation, but only on my computer.
  • Additional Changes: The README.md has been updated with the installation command for PyTorch-cu118.

@exx8
Copy link
Owner

exx8 commented Feb 22, 2024

First of all thank you twice!
First for the feedback and second for the PR.
I will review it soon.
Thank you again!

@exx8
Copy link
Owner

exx8 commented Feb 25, 2024

Sorry for the delay.
First the requirements.txt you suggest seems to be better,
and the install scripts are a great addition!
I am not sure why we need torchaudio, also IF requires SentencePiece, so I think to add it to the requirements.
What do you think? Thanks!
Again sorry for the delay it was very busy weekend.

Deleted `torchaudio`
Add `sentencepiece`, which is required for DeepFloyd/IF
Deleted `torchaudio` as it is not needed
@IndigoDosSantos
Copy link
Author

Thx for the review! You're right; sentencepiece is necessary for IF. I've added it to 'requirements.txt' and removed the nonsensical torchaudio from both installation scripts. 😅

After committing these minor changes, I tested all models. Everything worked fine except for IF. In Stage 3, IF loads 'stabilityai/stable-diffusion-x4-upscaler/unet/diffusion_pytorch_model.bin', which my antivirus flagged as infected with 'Trojan.Ciusky.CryptedAit.1'. It's also odd that diffusers chose this file over the available safetensors variant, as it usually prefers safetensors. While this could be a false positive, it's definitely best to err on the side of caution and not use IF until this is sorted out.

@exx8 exx8 mentioned this pull request Mar 25, 2024
@IndigoDosSantos IndigoDosSantos deleted the patch-1 branch June 9, 2024 15:04
@exx8
Copy link
Owner

exx8 commented Jun 9, 2024

Hi,

I'm sorry for the delayed response. I'm currently going through a demanding period.

If it's okay, I will use your suggestions in the future once I have the capacity to maintain the repo.

Thanks for your patience.

@IndigoDosSantos
Copy link
Author

Hey :)

No worries at all! I can assure you there is zero pressure from my side 🤗

@IndigoDosSantos IndigoDosSantos restored the patch-1 branch June 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants