Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose ::util:: symbols #10

Open
eyalroz opened this issue Feb 3, 2020 · 0 comments
Open

Don't expose ::util:: symbols #10

eyalroz opened this issue Feb 3, 2020 · 0 comments
Assignees
Labels
Task Something to be done in the codebase which does not fix a bug and does not enhance it per se.

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 3, 2020

Our library currently exposes symbols in the ::util:: namespace, which are only used internally. That shouldn't happen - others might want to use those names.

Here's an SO question about this issue..

For now, let's use a workaround - move a lot of the utility code into a nameapace - avoiding accidental dependencies by outside source but not making the symbols actually private.

@eyalroz eyalroz self-assigned this Feb 3, 2020
@eyalroz eyalroz added the Task Something to be done in the codebase which does not fix a bug and does not enhance it per se. label Feb 3, 2020
eyalroz pushed a commit that referenced this issue Feb 3, 2020
Workaround for exposed `::util::` symbols in the installed library - hoping for a better solution!
eyalroz pushed a commit that referenced this issue Feb 3, 2020
…rfering with code outside the library.

Note: This is a Workaround for exposed `::util::` symbols in the installed library - hoping for a better solution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Something to be done in the codebase which does not fix a bug and does not enhance it per se.
Projects
None yet
Development

No branches or pull requests

1 participant