This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
[DRAFT] Expose eyre features as color-eyre features #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change exposes all eyre features as color-eyre features, allowing you to test these dependency features combinatorially with `cargo test-all-features`. Default eyre features were added as default color-eyre features. As it stands the resulting test suite is extremely long, 256 runs, too long for CI. The --chunks feature can be used to split up and parallelize this process, but it's still a too much for CI as it exists. Maybe some of the eyre features could be added manually to the CI, but I don't know what combinations we'd be interested in - @pksunkara had some ideas though. If we reduce the combinatorial complexity some with a more restrained cargo-all-features configuration maybe that'd be something we'd like to pursue!
| @@ -12,10 +12,13 @@ categories = [] | |||
| keywords = [] | |||
|
|
|||
| [features] | |||
| default = ["track-caller", "capture-spantrace"] | |||
| default = ["track-caller", "capture-spantrace", "auto-install", "track-caller"] | |||
There was a problem hiding this comment.
Suggested change
| default = ["track-caller", "capture-spantrace", "auto-install", "track-caller"] | |
| default = ["auto-install", "capture-spantrace", "track-caller"] |
"track-caller" was in there twice. It's easier to spot in alphabetic order.
There was a problem hiding this comment.
eyre-rs/eyre#138 introduces "anyhow" as new eyre default feature flag.
eyre-rs/eyre#136 intends to make the new "anyhow" feature non-default in a breaking release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes all eyre features as color-eyre features, allowing you to test these dependency features combinatorially with
cargo test-all-features. Default eyre features were added as default color-eyre features.As it stands the resulting test suite is extremely long, 256 runs, too long for CI. The --chunks feature can be used to split up and parallelize this process, but it's still a too much for CI as it exists. Maybe some of the eyre features could be added manually to the CI, but I don't know what combinations we'd be interested in - @pksunkara had some ideas though. If we reduce the combinatorial complexity some with a more restrained cargo-all-features configuration maybe that'd be something we'd like to pursue!
p.s. all 256 tests passed on stable locally