Fix the deletion of /mnt while unmount Guest ISO #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the "state: absent" for ansible.posix.mount module on "Unmount VBoxGuestAdditions.iso" task, deletes the mounpoint, in this case, it's the `/mnt` directory. On the other hand, using the "state: unmounted" results stuck the Vagrant box while the creation of the VMs. Propose: Since it's a temporary ISO mount and unmount procedure, let's use a temporary fstab and do not touch the /etc/fstab at all. There's a long-awaited PR for adding "state: ephemeral" support to the ansible.posix.mount module[^1]. We can switch to use this option after the PR merged to the upstream. This patch can be tested on https://app.vagrantup.com/almalinux/boxes/8/versions/8.6.20220715 and https://app.vagrantup.com/almalinux/boxes/9/versions/9.0.20220715 Vagrant boxes. Fixes: AlmaLinux/cloud-images#72 [^1]: ansible-collections/ansible.posix#267 Signed-off-by: Elkhan Mammadli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the "state: absent" for ansible.posix.mount module
on "Unmount VBoxGuestAdditions.iso" task, deletes the mounpoint,
in this case, it's the
/mntdirectory.On the other hand, using the "state: unmounted" results stuck
the Vagrant box while the creation of the VMs.
Propose: Since it's a temporary ISO mount and unmount procedure,
let's use a temporary fstab and do not touch the /etc/fstab at all.
There's a long-awaited PR for adding "state: ephemeral"
support to the ansible.posix.mount module1.
We can switch to use this option after the PR merged to the upstream.
This patch can be tested on
https://app.vagrantup.com/almalinux/boxes/8/versions/8.6.20220715
and https://app.vagrantup.com/almalinux/boxes/9/versions/9.0.20220715
Vagrant boxes.
Fixes: AlmaLinux/cloud-images#72
Signed-off-by: Elkhan Mammadli [email protected]
Footnotes
https://github.com/ansible-collections/ansible.posix/pull/267 ↩