[google#23] Add logfile_mode to control logfile permissions

ezegomez · Sep 8, 2016 · 0e7bc43 · 0e7bc43
1 parent 4cdc2ed
commit 0e7bc43
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/glog/logging.h.in b/src/glog/logging.h.in
@@ -364,6 +364,9 @@ DECLARE_int32(minloglevel);
 // default logging directory.
 DECLARE_string(log_dir);
 
+// Set the log file mode.
+DECLARE_int32(logfile_mode);
+
 // Sets the path of the directory into which to put additional links
 // to the log files.
 DECLARE_string(log_link);

diff --git a/src/logging.cc b/src/logging.cc
@@ -164,6 +164,8 @@ static const char* DefaultLogDir() {
   return "";
 }
 
+GLOG_DEFINE_int32(logfile_mode, 0664, "Log file mode/permissions.");
+
 GLOG_DEFINE_string(log_dir, DefaultLogDir(),
                    "If specified, logfiles are written into this directory instead "
                    "of the default logging directory.");
@@ -911,7 +913,7 @@ bool LogFileObject::CreateLogfile(const string& time_pid_string) {
     //demand that the file is unique for our timestamp (fail if it exists).
     flags = flags | O_EXCL;
   }
-  int fd = open(filename, flags, 0664);
+  int fd = open(filename, flags, FLAGS_logfile_mode);
 
   if (fd == -1) return false;
 #ifdef HAVE_FCNTL