refactor: sort all top-level imports #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sort imports by external deps first, then local/internal deps next (AKA absolute imports first, then relative imports)
Details
basically, general format is:
path
) at the top half of externals, then core deps liketypescript
, then any other external depsthis is how I generally sort my imports and how I wrote most of the unit test suite's imports as well (c.f. test: add initial unit test suite #321)
there is automation for this that we should probably add once TSLint is replaced here; some previous art:
isort
ofc