Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: condense own tsconfig by removing defaults #343

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jun 4, 2022

Summary

Simplify the internal tsconfig used by rpt2 for rpt2 itself by removing configuration that is equivalent to the defaults

Details

- `pretty: true` and `noEmitOnError: false` are the defaults
  - https://www.typescriptlang.org/tsconfig#pretty
  - https://www.typescriptlang.org/tsconfig#noEmitOnError

- when `strict: true`, `noImplicitAny`, `noImplicitThis`, and
  `strictNullChecks` default to `true` as well
  - https://www.typescriptlang.org/tsconfig#strict
  - I've heavily contributed to the TSConfig docs and the docs for this
    property the most
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Jun 4, 2022
@agilgur5 agilgur5 changed the title refactor: condense own tsconfig by removing defaults clean: condense own tsconfig by removing defaults Jun 5, 2022
@ezolenko ezolenko merged commit 671281f into ezolenko:master Jun 7, 2022
@agilgur5 agilgur5 deleted the refactor-condense-tsconfig branch July 2, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants