refactor(test): use more specific checks in check-tsconfig spec
#398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `toBeFalsy()` was a bit imprecise and always felt as such, especially since `checkTsConfig` returns `void` - so instead check that it doesn't throw, which matches the test _intent_ - reorder the tests a bit to match existing test style: non-errors first, then errors - and separating into two different test blocks parallelizes them as well - also add an ES2020 check as well (follow-up to eb1dd17)
agilgur5
added
kind: internal
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Be more precise with the checks in
check-tsconfig.spec.tsand reorder things a bitcheck-tsconfig.spec.tsshould now match the structure ofparse-tsconfig.spec.tsfrom test: addparse-tsconfigspec #397Details
toBeFalsy()was a bit imprecise and always felt as such, especially sincecheckTsConfigreturnsvoidreorder the tests a bit to match existing test style: non-errors first, then errors
also add an ES2020 check as well
module: "ES2020"compatibility #376