Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(diagnostics): simplify some conditionals #402

Conversation

agilgur5
Copy link
Collaborator

Summary

Simplify some conditionals in print-diagnostics by reducing nesting

Details

  • reduce the complexity of the code by decreasing the amount of nesting

  • note that print returns void anyway, so calling it within the return statement doesn't change anything

    • and this is within a void forEach at that too

- reduce the complexity of the code by decreasing the amount of nesting

- note that `print` returns `void` anyway, so calling it within the `return` statement doesn't change anything
  - and this is within a `void` `forEach` at that too
@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label Jul 29, 2022
@ezolenko ezolenko merged commit c37dbf6 into ezolenko:master Aug 8, 2022
@agilgur5 agilgur5 deleted the refactor-diagnostics-simplify-conditionals branch July 2, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants