Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmap-alloc: Tests fail on Mac Travis CI #120

Closed
joshlf opened this issue Oct 24, 2017 · 3 comments
Closed

mmap-alloc: Tests fail on Mac Travis CI #120

joshlf opened this issue Oct 24, 2017 · 3 comments

Comments

@joshlf
Copy link
Collaborator

joshlf commented Oct 24, 2017

On Mac Travis CI, we're getting odd test failures for the mmap-alloc crate with a SIGBUS in the test_map_panic_too_large test.

For example, this build:

Running `/Users/travis/build/ezrosent/allocators-rs/mmap-alloc/target/debug/deps/mmap_alloc-78657eb3ad591fbe`
running 11 tests
test tests::bench_large_map ... ignored
test tests::test_commit ... ok
test tests::test_map ... ok
test tests::test_map_non_windows ... ok
test tests::test_map_panic_too_large ... error: process didn't exit successfully: `/Users/travis/build/ezrosent/allocators-rs/mmap-alloc/target/debug/deps/mmap_alloc-78657eb3ad591fbe` (signal: 10, SIGBUS: access to undefined memory)

This issue has not come up on master yet, but is currently only present on the tls branch (PR #85), which is particularly odd since no changes to mmap-alloc are made on that branch.

@joshlf
Copy link
Collaborator Author

joshlf commented Nov 1, 2017

This issue has come up in #122 as well.

joshlf added a commit that referenced this issue Nov 1, 2017
@joshlf
Copy link
Collaborator Author

joshlf commented Nov 1, 2017

OK, it looks like the issue is just that mmap-alloc tests are failing in general on Travis Mac, not just test_map_panic_too_large in particular. I'll update the PR to disable on Mac entirely.

joshlf added a commit that referenced this issue Nov 1, 2017
joshlf added a commit that referenced this issue Nov 1, 2017
@joshlf joshlf changed the title mmap-alloc: Fix failures on Mac Travis CI mmap-alloc: Tests fail on Mac Travis CI Nov 8, 2017
@joshlf
Copy link
Collaborator Author

joshlf commented Nov 8, 2017

Looks like this might be the culprit: rust-lang/rust#45866. After it lands in nightly tomorrow, we should re-enable these tests to see if that change fixes it.

joshlf added a commit that referenced this issue Nov 11, 2017
@joshlf joshlf closed this as completed in ac97509 Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant