EZP-29746: Selected item blinking while loading its children in UDW #111
Conversation
| locationsMap: this.locationsMap, | ||
| activeLocations: this.activeLocations, | ||
| }), | ||
| () => ({ locationsMap: this.locationsMap, activeLocations: this.activeLocations }), |
There was a problem hiding this comment.
If you created setPreselectedState method you can use it here.
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <SelectContentButtonComponent | ||
| multiple={multiple} | ||
| selectedContent={selectedContent} | ||
| isSelected={selectedContent.find((content) => content.id === location.id)} |
There was a problem hiding this comment.
isSelected suggests it's boolean but is passed content?
|
ping @dew326 |
| @@ -69,13 +61,14 @@ export default class FinderTreeBranchComponent extends Component { | |||
| const contentTypeHref = location.ContentInfo.Content.ContentType._href; | |||
| const isContainer = contentTypesMap && contentTypesMap[contentTypeHref] && contentTypesMap[contentTypeHref].isContainer; | |||
| const isSelectable = !(this.props.allowContainersOnly && !isContainer); | |||
| const selected = location.id === this.state.selectedItem; | |||
There was a problem hiding this comment.
I would go for selectedLocationId instead of selectedItem because for the former is more descriptive.
| isLocationAllowed, | ||
| isPreviewMetaReady: false, | ||
| })); | ||
| this.setState(() => ({ |
There was a problem hiding this comment.
Why we are setting these state's variables here and not in the first callback? We are waiting for this.props.cotfAllowedLocations to change or somehow influence rendering order? I don't understand idea behind it.
There was a problem hiding this comment.
It seems to me that we want to reset something? Why would we need that?
| hasChildrenClassName, | ||
| isLoadingChildrenClassName, | ||
| isNotSelectableClassName, | ||
| ].join(' '), |
There was a problem hiding this comment.
I would go for helper function accepting object { 'some-class-name': true | false }.
There was a problem hiding this comment.
I get your point, but we won't do it now.
|
@sunpietro looks like it needs a rebase. :) |
sunpietro
force-pushed
the
fix-udw-selecting-items
branch
from
892de3a
to
e0bade3
Compare
|
@micszo branch has just been rebased |
|
Follow-up issue https://jira.ez.no/browse/EZP-29759. |
|
@sunpietro you can merge it up |
https://jira.ez.no/browse/EZP-29746