EZP-29996: Move CSS files for Universal Discovery Module to Admin UI #130
Conversation
sunpietro
added
Improvement
Ready for review
Ready for QA
and removed
Work in progress
labels
sunpietro
changed the title
| <use xlinkHref="/bundles/ezplatformadminui/img/ez-icons.svg#spinner" /> | ||
| </svg> | ||
| ); | ||
| return <Icon name="spinner" extraClasses="ez-spin ez-icon-x2 ez-icon--small ez-icon--light" />; |
There was a problem hiding this comment.
It might be good time to delete ez-icon-x2 which is redundant and occurs in several files. But for me it's not deal-breaker. 🙂
| className="c-upload-list-item__action c-upload-list-item__action--abort" | ||
| onClick={this.abortUploading} | ||
| title={label} | ||
| tabIndex="-1" |
There was a problem hiding this comment.
I don't think we need to set tabIndex="-1" for divs which are not focusable by default.
There was a problem hiding this comment.
Me and @dew326 discussed this in private and as Dariusz noted that:
A negative value (usually tabindex="-1") means that the element should be focusable, but should not be reachable via sequential keyboard navigation. It's mostly useful to create accessible widgets with JavaScript.
source: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex
dew326
force-pushed
the
ezp-29996-udw-move-css-files
branch
from
84c0457
to
0df47a8
Compare
|
@micszo changed base branch, rebased with master, fixed issue with UDW. Ready for re-test. |
|
Only Time TCs failed. |
https://jira.ez.no/browse/EZP-29996
THINGS DONE
Iconcomponent instead of raw HTML tags,