EZP-30072: As an editor I would like to see the content tree state restored after reloading a page #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
force-pushed
the
EZP-30072-restore-Contet-Tree-after-reload
branch
from
fa02300
to
ba4bd68
Compare
tischsoic
force-pushed
the
EZP-30072-restore-Contet-Tree-after-reload
branch
from
7d6f0a4
to
e78463b
Compare
tischsoic
changed the title
|
Ready for review - ping @dew326 |
dew326
requested changes
Feb 28, 2019
| const mapChildrenToSubitemsDeep = (tree) => { | ||
| const parsedSubtree = []; | ||
|
|
||
| for (const subtree of tree) { |
| const mapChildrenToSubitems = (location) => { | ||
| location.totalSubitemsCount = location.totalChildrenCount; | ||
| location.subitems = location.children; | ||
| location.totalSubitemsCount = location.totalChildrenCount; |
There was a problem hiding this comment.
Maybe after rebase.
| nodes: subtree, | ||
| }, | ||
| }), | ||
|
|
| return; | ||
| } | ||
|
|
||
| const index = parentSubtree.children.findIndex((element) => parseInt(element.locationId, 10) === parseInt(path[1], 10)); |
There was a problem hiding this comment.
The other element.locationId doesn't have parseInt
There was a problem hiding this comment.
Yup, it can be removed.
| localStorage.setItem(KEY_CONTENT_TREE_SUBTREE, JSON.stringify(this.subtree)); | ||
| } | ||
|
|
||
| findParentSubtree(subtree, item, path) { |
tischsoic
force-pushed
the
EZP-30072-restore-Contet-Tree-after-reload
branch
from
9f7cedd
to
435e76b
Compare
|
ping @dew326 - I applied fixes in last commit. :) |
dew326
requested changes
Feb 28, 2019
|
|
||
| return mapChildrenToSubitems(location); | ||
| }) | ||
| .then(callback) | ||
| .catch(showErrorNotification); | ||
| // .catch(showErrorNotification); |
dew326
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-30072
Requires: ezsystems/ezplatform-admin-ui#857
Screenshots
Restoring tree state after page refresh:
Resizing Content Tree container according to windows size & scroll: