EZP-30232: Item highlight is cropped in Content Tree with scroll #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
commented
Mar 6, 2019
|
|
||
| .m-tree__scrollable-wrapper { | ||
| > .c-list { | ||
| display: table; |
There was a problem hiding this comment.
I also tried solutions with
display: inline-blockdisplay: flex; align-items: stretch;on.m-tree__scrollable-wrapper
but they didn't work. I know that table layouts are taboos in CSS world but this solutions seems to work perfectly.
If you have better idea @dew326 I will gladly hear it. 🙂
There was a problem hiding this comment.
Do we want to move this to _main.scss or leave it here? I added it here because it styles c-list.
There was a problem hiding this comment.
I think adding hover state on c-list-item__link should solve the problem.
There was a problem hiding this comment.
It's interesting idea, but it won't work with shorter items - we want all highlights to stretch to the right side of the container. Problematic example:
dew326
approved these changes
Mar 6, 2019
micszo
approved these changes
Mar 6, 2019
lserwatka
deleted the
EZP-30232-item-highlight-is-cropped-in-Content-Tree-with-scroll
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-30232
Before
After