EZP-30245: Bulk delete - item is removed to trash, but user gets permission message #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Mar 18, 2019
ViniTou
force-pushed
the
EZP-30245-bulk-delete-multiple-locations
branch
from
e44be68
to
d30dfb6
Compare
tischsoic
requested changes
Mar 18, 2019
| const { operations } = response.BulkOperationResponse; | ||
| const locationsMatches = Object.entries(operations).reduce( | ||
| (locationsMatches, [locationId, response]) => { | ||
| const respectiveItem = locations.find((location) => location.id === parseInt(locationId, 10)); | ||
| const isSuccess = response.statusCode === successCode; | ||
| const isSuccess = 200 <= response.statusCode <= 299; |
There was a problem hiding this comment.
200 <= 400 <= 299 returns true
Suggested change
| const isSuccess = 200 <= response.statusCode <= 299; | |
| const isSuccess = 200 <= response.statusCode && response.statusCode <= 299; |
ViniTou
force-pushed
the
EZP-30245-bulk-delete-multiple-locations
branch
from
d30dfb6
to
21c93de
Compare
dew326
approved these changes
Mar 18, 2019
tischsoic
approved these changes
Mar 18, 2019
barbaragr
approved these changes
Mar 18, 2019
|
@ViniTou rebase is required. |
ViniTou
force-pushed
the
EZP-30245-bulk-delete-multiple-locations
branch
from
21c93de
to
a83af3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
When location which is tied with content with other locations is moved to trash,
204code instead of hardcoded201is returned.