EZP-30326: As a user I want to see if my search in UDW has no results #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
commented
Mar 22, 2019
| @@ -45,7 +45,8 @@ | |||
| } | |||
|
|
|||
| .c-search__submit[disabled] { | |||
| opacity: 0.75; | |||
| opacity: 0.3; | |||
| cursor: not-allowed; | |||
There was a problem hiding this comment.
Note: I slightly changed styles of:
to match:
both in disabled state.
dew326
requested changes
Mar 22, 2019
| @@ -41,7 +36,6 @@ export default class BookmarksComponent extends Component { | |||
| perPage={bookmarksPerPage} | |||
| contentTypesMap={contentTypesMap} | |||
| title={tableTitle} | |||
| noItemsMessage={noBookmarksMessage} | |||
There was a problem hiding this comment.
Why bookmark tables will not have this message anymore?
There was a problem hiding this comment.
It was never used in Bookmarks, it must have stayed after some modifications in the past.
| } | ||
|
|
||
| const searchTipsTitle = Translator.trans(/*@Desc("Some helpful search tips:")*/ 'search.tips.headline', {}, 'search'); | ||
| const searchTip1 = Translator.trans(/*@Desc("Check spelling of keywords.")*/ 'search.tips.check_spelling', {}, 'search'); |
There was a problem hiding this comment.
Please, never ever use a variable named text{number}
| canSelectContent={canSelectContent} | ||
| onItemRemove={onItemRemove} | ||
| multiple={multiple} | ||
| noItemsMessage={`Sorry, no results were found for "${lastSearchText}".`} |
…' message + search tips
tischsoic
force-pushed
the
EZP-30326-as-user-I-want-to-see-if-my-search-in-UDW-has-no-results
branch
from
032ef4c
to
8a5a00a
Compare
dew326
approved these changes
Mar 26, 2019
katarzynazawada
approved these changes
Mar 26, 2019
lserwatka
deleted the
EZP-30326-as-user-I-want-to-see-if-my-search-in-UDW-has-no-results
branch
|
You can merge it up. |
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-30326
Requires: ezsystems/ezplatform-admin-ui#920
Screenshot