EZP-27092: Remove eZAutoLink operator usage of preg_replace and PREG_REPLACE_EVAL #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…REG_REPLACE_EVAL add unit tests
brookinsconsulting
changed the title
|
+1 |
|
Hello eZ Community, @pkamps Thank you for your show of support. Question: What more can we do to here in this pull request to move it forward and for it to be merged? Cheers, |
brookinsconsulting
deleted the
preg_replace_slash_e_modifier_deprecation_since_php55
branch
petrmifek
added a commit
to petrmifek/ezpublish-legacy
that referenced
this pull request
May 23, 2017
* master: (40 commits) A quick hack to support html entities in RSS imported item descriptions. Fix EZP-27321: Update TinyMCE to 3.5.12 and patch for "Uncaught DOMEx… (ezsystems#1297) EZP-27011: Solr index not updated when changing a content priority (ezsystems#1283) EZP-15983 - Only include ezp_override when present (ezsystems#1270) Add state change/assign to the audit log (ezsystems#1285) EZP-27092: Remove eZAutoLink operator usage of preg_replace and PREG_REPLACE_EVAL (ezsystems#1286) Fix EZP-26911: Embedded PDF files are downloadable though they are in trash EZP-27000: Remove uploader.swf from all repos/branches Fix EZP-26659: The package component is vulnerable to arbitrary file upload Fix EZP-26405: SQL Injection in Search Component (ezsearchengine) Setting to have different cache based on the request protocol Fix EZP-26832: Enabling editor causes error on links with "&" (ezsystems#1278) Making sure all affected PHP versions are handled Fix EZP-26798: Query parameters get lost when being redirected with mobile device detect filter Fix EZP-26405: SQL Injection in Search Component (ezsearchengine) (ezsystems#105) Fix EZP-26449: Wrong version translation list in eZContentOperationCollection Fix EZP-26427: ezoe popup search string not urlencoded Fix EZP-26354: Autolink fails if you try to link content in your own site (ezsystems#1263) Fix EZP-25031: eZContentUpload is not providing original file name to custom UploadHandler (ezsystems#1228) Fix EZP-26276: Exclamation mark followed by non-chars at end of URL does not work in emails (ezsystems#1260) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://jira.ez.no/browse/EZP-27092
Remove eZAutoLink operator usage of preg_replace usage of "\e" (PREG_REPLACE_EVAL) to properly support php 5.5+ and php 7.0+
Since PHP 5.5.x the usage of preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL) and preg_replace_callback() should be used instead. IE: Deprecation of feature usage.
Since PHP 7.x the usage of preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL) and preg_replace_callback() must be used instead. IE: Removal of feature usage.
Source #1, Deprecated features in PHP 5.5.x: http://php.net/manual/en/migration55.deprecated.php
Source #2, Changed functions in PHP 7.x: http://php.net/manual/en/migration70.changed-functions.php
Description Summary: preg_replace() function no longer supports "\e" (PREG_REPLACE_EVAL). preg_replace_callback() should be used instead.
Our pull request will address these problems by refactoring the affected code and add phpunit tests to ensure the results remain the same through these code changes.
Cheers,
Brookins Consulting