Implemented EZP-20787: fiximagesoutsidevardir improvements #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 29, 2013 16:20
If the var folder was renamed after the setting was changed, the database contains references to imates in the old path. The update script is now able to detect this, and will update the database references without trying to move the files.
| } | ||
| else | ||
| { | ||
| $moveFiles = true; |
There was a problem hiding this comment.
s/moveFiles/moveFile/ ?
There was a problem hiding this comment.
Good point. I can actually completely remove this block.
|
Apart remark from @patrickallaert, +1 |
|
Other than my remark: +1 |
|
+1 for >=5.1 with fix for issue pointed out by @patrickallaert |
|
Alright, enough +1, merging (Patrick's remark fixed in 6326e45). |
|
Manually merged in c684e25 |
ernestob
added a commit
to ernestob/ezpublish-legacy
that referenced
this pull request
Sep 6, 2019
…jax call to update all the priorities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://jira.ez.no/browse/EZP-20787.
Makes the update script support the use-case where both the setting AND the vardir were changed, but existing images references haven't been updated.